MyBB Community Forums

Full Version: Rin Editor 1.2.4 (Powerd by CKEditor)
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Hello,

Nice plugin !! but you should not use a develpment version of ckeditor it is outright dangerous security wise.You are providing ckeditor version 4.16.0 while the latest official release is 4.15.1 any good reason for that ?
1.1.0 Released

Change log:
https://community.mybb.com/mods.php?acti...og&pid=657

How update:
1.0.5 or above:

1 - Replace the files with new version

2 - Open and edit:
Home » Template Sets » Global Templates » Edit Template: rinbutquick

Find:
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/rin/editor/rineditor.js?ver=x.x.x"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/rin/editor/ckeditor.js?ver=x.x.x"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/rin/editor/adapters/jquery.js?ver=x.x.x"></script>

Replace x.x.x with new version number.

1.0.5 or below:

- Unistall old version.
- Upload new version.
- Install new version.

(2020-12-22, 10:18 AM)Erikbe Wrote: [ -> ]Hello,

Nice plugin !! but you should not use a develpment version of ckeditor it is outright dangerous security wise.You are providing ckeditor version 4.16.0 while the latest official release is 4.15.1 any good reason for that ?

The version I use is the initial version of 4.16.0 is practically the same as 4.15.1 but includes the following bug fix:

1 - https://github.com/ckeditor/ckeditor4/issues/2800
2 - https://github.com/ckeditor/ckeditor4/issues/1134

Nobody is forcing you to use this plugin. If you think this plugin is not safe, just don't use it.
(2020-12-18, 04:41 AM)martec Wrote: [ -> ]could you try an attachment version of this post?

if patch work could you give me which operating system, browser and browser version you are using? because i can't reproduce for windows using blink and gecko based browser...  maybe you are using safari? if this happen with safari, i need too patch the phpbb version.

Hi, I did a basic replace of files (no uninstall, no deactivate, etc) and it seems to fix the issue. I don't know if it causes other issues though, I would assume it doesn't at this moment.

As a suggestion, getting templates, settings, and even template variables removed on minimal updates is very unfriendly. I would suggest to consider something like PluginLibrary to manage settings and templates, or something own-coded.

Regards, keep it up. Smile

Edit: It seems your last update included the fix you attached. I did test the attached package but not the update in the Extend site.
Yes, easier way how to upgrade would be welcome! Keep settings and templates changes would be great.
Tips: How unofficially enable imgur drag and drop support

Requirement: Working imgur button.
Requirement2: If you want enable too for copy and paste image, require Rin Editor 1.0.8 or above.


Caution: This is unofficial modification. I will not support issues related with this.

PS: This only will work in wysiwyg mode

What does it do: The editor in WYSIWYG mode means in visual mode, it will automatically upload the image for imgur in the following cases:

- drag and drop (drag and drop the image into the editor)
- Copy and paste MS Word images (in this case it doesn't matter how many images or if you selected the text or not)

The feature below require Rin Editor 1.0.8 or above and you must enable Unofficial support for base64 images:
(https://community.mybb.com/thread-189422...pid1359753)

- copy the image from any website and paste it in the editor (you should just copy an image (right button on top of the image and select copy the image in the case of FF), if you select the image and text this will not work)

Caution: This feature uses base64 images (https://github.com/ckeditor/ckeditor4/bl...s#L96-L100), it means that all images that you will insert or converted by ckeditor to this format will uploaded to the imgur. So when you activate this, you are unable to use images in base64.

Steps:

1 - Download the following package:

For Rin Editor 1.1.1 or above
https://github.com/martec/imgur_drag_and.../0.0.2-new

For Rin Editor 1.1.0 or below
https://github.com/martec/imgur_drag_and.../tag/0.0.1

2 - Extract No. 1 to: root/jscripts/rin/editor/plugins

3 - Open and edit  root/jscripts/rin/editor/config.js

Find:

config.language = rinlanguage;

add above:

For Rin Editor 1.1.1 or above
config.extraPlugins = 'filetools,imgur_drag,notificationaggregator,uploadimage,uploadwidget';

For Rin Editor 1.1.0 or below
config.extraPlugins = 'filetools,imgur_drag,lineutils,notificationaggregator,uploadimage,uploadwidget,widget,widgetselection';

Find:

config.image_previewText = ' ';

Add below:

config.imageUploadUrl = 'https://api.imgur.com/3/image';

4 - Clear your browser's cache, if you're using cloudflare, you also need to clear your cloudflare cache (https://support.cloudflare.com/hc/en-us/...Cloudflare).

it's all.

(2020-12-23, 11:09 PM)Omar G. Wrote: [ -> ]Hi, I did a basic replace of files (no uninstall, no deactivate, etc) and it seems to fix the issue. I don't know if it causes other issues though, I would assume it doesn't at this moment.

I'm glad it worked. could you tell me which browser and operating system you use to comment on this part of the code?

(2020-12-23, 11:09 PM)Omar G. Wrote: [ -> ]As a suggestion, getting templates, settings, and even template variables removed on minimal updates is very unfriendly. I would suggest to consider something like PluginLibrary to manage settings and templates, or something own-coded.

Regards, keep it up. Smile

sorry i was copying and pasting the update method for my convenience.

usually replacing the files and making the following changes is enough.

Open and edit:
Home » Template Sets » Global Templates » Edit Template: rinbutquick

Find:
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/rin/editor/rineditor.js?ver=x.x.x"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/rin/editor/ckeditor.js?ver=x.x.x"></script>
<script type="text/javascript" src="{$mybb->asset_url}/jscripts/rin/editor/adapters/jquery.js?ver=x.x.x"></script>

Replace x.x.x with new version number.

In the next version I will better guide this part.

(2020-12-23, 11:09 PM)Omar G. Wrote: [ -> ]Edit: It seems your last update included the fix you attached. I  did test the attached package but not the update in the Extend site.

it's same. But only version number is different to differentiate from the official version from unofficial.
Quote:I'm glad it worked. could you tell me which browser and operating system you use to comment on this part of the code?

I use Windows 10 64 bits, Google Chrome Versión 87.0.4280.88 (Build oficial) (64 bits)
(2020-12-24, 06:46 AM)Omar G. Wrote: [ -> ]
Quote:I'm glad it worked. could you tell me which browser and operating system you use to comment on this part of the code?

I use Windows 10 64 bits, Google Chrome Versión 87.0.4280.88 (Build oficial) (64 bits)

thanks for information. This will help me.
Bug report - new lines are ignored when you add an image via imgur (maybe ven with other ways). Testing text:

[align=center][b][size=medium][color=#8e44ad]A lot of text here in the header [/color][/size][/b]
[/align]



[align=center][img]https://i.imgur.com/ExUcjZu.jpg[/img][/align]

It happens only in wysiwyg mode, just try to add "enter" new lines between the image and text and save the post.
(2020-12-24, 10:31 AM)Eldenroot Wrote: [ -> ]Bug report - new lines are ignored when you add an image via imgur (maybe ven with other ways). Testing text:

[align=center][b][size=medium][color=#8e44ad]A lot of text here in the header [/color][/size][/b]
[/align]



[align=center][img]https://i.imgur.com/ExUcjZu.jpg[/img][/align]

It happens only in wysiwyg mode, just try to add "enter" new lines between the image and text and save the post.

Are you saying about space between text and image with alignment tag?
here in clean installation working fine... No issue for me....

the demo site using old version.... but for me same result....
could you check if you can reproduce in demo site?

Demo:

https://sites.minnasuki.com/1820

popup user and password

user: test
pass: test123

user and password in test forum

user: testuser
pass: test123
I have tested, works fine... maybe uploading via imgur would break it (no imgur button in your testing board, so cannot test)? Tested multiple times on my board...

In my case new lines are deleted, I have to add them in source mode and then it is fine... I will try to check later in different browser Sad thank you for your input anyway.

Also quite difficult to update to newer version with all custom modifications - tables, drag and drop, base64 support etc. Maybe would be great to add them as an experimental part into ACP settings (not all, just the images related) Smile thank you for your support of this great plugin!