2010-06-29, 11:21 PM
This is really good but I see a lot of stuff in ROOT/ezgallery.php that could be improved.
Examples are things like this may not work on MyBB.
while($row = mysql_fetch_assoc($dbresult))
You should use the $db class. I know that sometimes trying to use mysql functions won't work under certain circumstances.
That should be $db->simple_select not a write_query.
You also don't use templates and for consistency sake you should.
I give this plugin a big thumbs up. It's a great attempt to make a solid gallery plugin. With a little adjustment to make this more standard for MyBB and it would be perfect.
I'd like to encourage you to further develop this. A day of work and you could have the best gallery plugin for mybb.
Examples are things like this may not work on MyBB.
while($row = mysql_fetch_assoc($dbresult))
You should use the $db class. I know that sometimes trying to use mysql functions won't work under certain circumstances.
// Search for members who have this picture id set in their GET data.
$request = $db->write_query("
That should be $db->simple_select not a write_query.
You also don't use templates and for consistency sake you should.
I give this plugin a big thumbs up. It's a great attempt to make a solid gallery plugin. With a little adjustment to make this more standard for MyBB and it would be perfect.
I'd like to encourage you to further develop this. A day of work and you could have the best gallery plugin for mybb.